Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add sort in head of tables #3580

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review November 28, 2024 11:44
Copy link

sonarcloud bot commented Nov 28, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.71429% with 31 lines in your changes missing coverage. Please review.

Project coverage is 66.62%. Comparing base (dbb58e7) to head (0222cea).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...adiation-form/decision-radiation-form.component.ts 9.09% 10 Missing ⚠️
.../usager-shared/services/usager-decision.service.ts 0.00% 8 Missing ⚠️
...app/shared/store/usager-actions-reducer.service.ts 0.00% 5 Missing ⚠️
...ge-usagers-table/manage-usagers-table.component.ts 75.00% 3 Missing ⚠️
...nd/src/app/modules/shared/pipes/sort-array.pipe.ts 33.33% 2 Missing ⚠️
...omponents/delete-usager/delete-usager.component.ts 50.00% 2 Missing ⚠️
...nage-usagers-page/manage-usagers-page.component.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3580      +/-   ##
==========================================
+ Coverage   66.59%   66.62%   +0.03%     
==========================================
  Files         914      916       +2     
  Lines       14991    15006      +15     
  Branches     2118     2120       +2     
==========================================
+ Hits         9983     9998      +15     
- Misses       4834     4970     +136     
+ Partials      174       38     -136     
Files with missing lines Coverage Δ
...kages/frontend/src/_common/model/_general/index.ts 100.00% <100.00%> (ø)
...ge-usagers-page/manage-usagers-page.component.html 100.00% <ø> (ø)
...nts/manage-usagers-table/manage-usagers-table.html 100.00% <ø> (ø)
.../components/usager-filter/UsagersFilterCriteria.ts 100.00% <ø> (ø)
...pp/modules/manage-usagers/manage-usagers.module.ts 100.00% <100.00%> (ø)
.../manage-usagers/utils/sorter/dataSorter.service.ts 97.36% <100.00%> (+0.07%) ⬆️
...head-sort-icon/table-head-sort-icon.component.html 100.00% <100.00%> (ø)
...e-head-sort-icon/table-head-sort-icon.component.ts 100.00% <100.00%> (ø)
...nts/table-head-sort/table-head-sort.component.html 100.00% <ø> (ø)
...nents/table-head-sort/table-head-sort.component.ts 50.00% <100.00%> (-11.12%) ⬇️
... and 19 more

... and 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb58e7...0222cea. Read the comment docs.

@pYassine pYassine merged commit f08928f into master Nov 28, 2024
11 of 12 checks passed
@pYassine pYassine deleted the feat-add-columns-sort branch November 28, 2024 11:49
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.186.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants