Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): refactor search to enforce performances #3577

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review November 28, 2024 00:47
@pYassine pYassine requested a review from a team as a code owner November 28, 2024 00:47
Copy link

socket-security bot commented Nov 28, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

Report too large to display inline

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 66.59%. Comparing base (9da2b21) to head (72dff64).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...lter/services/usagersSearchStringFilter.service.ts 52.17% 11 Missing ⚠️
.../components/usager-filter/usagersFilter.service.ts 67.85% 9 Missing ⚠️
...nage-usagers-page/manage-usagers-page.component.ts 25.00% 3 Missing ⚠️
...ponents/manage-filters/manage-filters.component.ts 50.00% 2 Missing ⚠️
.../manage-usagers/utils/sorter/dataSorter.service.ts 97.14% 1 Missing ⚠️
...nd/src/app/modules/shared/services/auth.service.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3577      +/-   ##
==========================================
- Coverage   66.68%   66.59%   -0.10%     
==========================================
  Files         919      914       -5     
  Lines       15048    14991      -57     
  Branches     2115     2118       +3     
==========================================
- Hits        10035     9983      -52     
+ Misses       4845     4834      -11     
- Partials      168      174       +6     
Files with missing lines Coverage Δ
.../src/_migrations/1731349672897-manual-migration.ts 12.19% <100.00%> (+2.19%) ⬆️
...tabase/entities/usager/UsagerSubscriber.typeorm.ts 95.45% <100.00%> (ø)
...kend/src/usagers/controllers/usagers.controller.ts 52.00% <100.00%> (ø)
packages/backend/src/util/index.ts 100.00% <ø> (ø)
...nents/contact-support/contact-support.component.ts 48.61% <100.00%> (ø)
...nts/manage-usagers-table/manage-usagers-table.html 100.00% <ø> (ø)
.../components/usager-filter/UsagersFilterCriteria.ts 100.00% <100.00%> (ø)
.../services/checkers/usagerPassageChecker.service.ts 80.00% <100.00%> (-1.82%) ⬇️
...ts/usager-filter/services/usagersSorter.service.ts 96.96% <100.00%> (+13.99%) ⬆️
...pp/modules/manage-usagers/pipes/sort-label.pipe.ts 58.33% <ø> (ø)
... and 10 more

... and 115 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da2b21...72dff64. Read the comment docs.

Copy link

🎉 Deployment for commit 2eaec0c :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-2eaec0ce40806788613cd11a3db865236f3b87db
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-2eaec0ce40806788613cd11a3db865236f3b87db
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-2eaec0ce40806788613cd11a3db865236f3b87db
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-2eaec0ce40806788613cd11a3db865236f3b87db
Debug

@pYassine pYassine merged commit dbb58e7 into master Nov 28, 2024
8 of 9 checks passed
@pYassine pYassine deleted the feat-add-select-multiple branch November 28, 2024 01:24
Copy link

sonarcloud bot commented Nov 28, 2024

@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.186.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants