Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): delete useless components #3515

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

pYassine
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.4% Duplication on New Code (required ≤ 15%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.24%. Comparing base (b2df8c4) to head (80f9e1d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...er/components/step-header/step-header.component.ts 71.42% 2 Missing ⚠️
...ponents/step-documents/step-documents.component.ts 0.00% 1 Missing ⚠️
...ponents/step-entretien/step-entretien.component.ts 0.00% 1 Missing ⚠️
...nents/step-etat-civil/step-etat-civil.component.ts 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
- Coverage   67.24%   67.24%   -0.01%     
==========================================
  Files         896      896              
  Lines       14770    14769       -1     
  Branches     2088     2093       +5     
==========================================
- Hits         9932     9931       -1     
+ Misses       4798     4683     -115     
- Partials       40      155     +115     
Files with missing lines Coverage Δ
...e-doc/constants/DOCUMENT_EXTENSION_LABELS.const.ts 100.00% <ø> (ø)
...ommon/model/telephone/PREFERRED_COUNTRIES.const.ts 100.00% <ø> (ø)
...ages/frontend/src/_common/model/telephone/index.ts 100.00% <100.00%> (ø)
...model/usager/entretien/ETAPES_DEMANDE_URL.const.ts 100.00% <ø> (ø)
...ontend/src/_common/model/usager/entretien/index.ts 100.00% <100.00%> (ø)
...ackages/frontend/src/_common/model/usager/index.ts 100.00% <ø> (ø)
...p/modules/import-usagers/import-usagers.service.ts 71.42% <ø> (ø)
...ponents/manage-filters/manage-filters.component.ts 71.87% <100.00%> (ø)
...ge-usagers-table/manage-usagers-table.component.ts 59.45% <100.00%> (ø)
...r/services/checkers/usagerStatutChecker.service.ts 100.00% <100.00%> (ø)
... and 41 more

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2df8c4...80f9e1d. Read the comment docs.

@pYassine pYassine merged commit eba11fe into master Oct 16, 2024
10 of 12 checks passed
@pYassine pYassine deleted the feat-delete-admin-stats branch October 16, 2024 11:44
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.178.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants