Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): amélioration des linters, correction d'un bug sur Safari #2938

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Sep 4, 2023

No description provided.

@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 20.4.7 None +0 3.82 MB types
eslint-plugin-no-lookahead-lookbehind-regexp 0.3.0 None +0 38.2 kB jonasbadalic
eslint-plugin-import 2.28.1 None +12 1.45 MB ljharb
@commitlint/cli 17.7.0...17.7.1 None +3/-3 3.89 MB escapedcat

🚮 Removed packages: [email protected], [email protected], [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #2938 (895c068) into master (88ad64b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2938      +/-   ##
==========================================
+ Coverage   68.01%   68.03%   +0.02%     
==========================================
  Files         918      919       +1     
  Lines       14577    14580       +3     
  Branches     2129     2127       -2     
==========================================
+ Hits         9914     9919       +5     
+ Misses       4392     4391       -1     
+ Partials      271      270       -1     
Files Changed Coverage
...c/structures/services/structure-deletor.service.ts ø
...rs/controllers/usager-structure-docs.controller.ts ø
.../src/usagers/controllers/usager-docs.controller.ts 100.00%
...ers/services/custom-docs/buildCustomDoc.service.ts 100.00%
...d/src/util/expressResponseExcelRenderer.service.ts 100.00%
...rontend/src/app/modules/shared/directives/index.ts 100.00%
...app/modules/shared/pipes/format-big-number.pipe.ts 100.00%
...ges/frontend/src/app/modules/shared/pipes/index.ts 100.00%
...s/frontend/src/app/modules/shared/shared.module.ts 100.00%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ad64b...895c068. Read the comment docs.

@pYassine pYassine temporarily deployed to review-auto September 4, 2023 13:22 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

🎉 Deployment for commit 895c068 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-895c068834621c02830c04bcc473daaa7ed5b4ca
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-895c068834621c02830c04bcc473daaa7ed5b4ca
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-895c068834621c02830c04bcc473daaa7ed5b4ca
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-895c068834621c02830c04bcc473daaa7ed5b4ca
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pYassine pYassine merged commit b46db82 into master Sep 4, 2023
7 of 8 checks passed
@pYassine pYassine deleted the fix-display-in-safari branch September 4, 2023 16:51
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.134.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants