Use Whippet #282
Draft
Use Whippet #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smaug123
commented
Oct 6, 2024
| <CurriedNoAttr>GenerateMock</CurriedNoAttr> | ||
| <TypeWithInterfaceNoAttr>GenerateMock</TypeWithInterfaceNoAttr> | ||
| </MyriadParams> | ||
| <WhippetFile>MockExampleNoAttributes.fs</WhippetFile> |
There was a problem hiding this comment.
Made the choice to flatten these params, because the contents of this XML node are presented through msbuild only as a string, not as an XML node!
Smaug123
commented
Oct 6, 2024
| </Compile> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="RestEase" Version="1.6.4"/> | ||
| <ProjectReference Include="..\WoofWare.Myriad.Plugins.Attributes\WoofWare.Myriad.Plugins.Attributes.fsproj" /> | ||
| <ProjectReference Include="..\WoofWare.Myriad.Plugins\WoofWare.Myriad.Plugins.fsproj" PrivateAssets="all" /> | ||
| <PackageReference Include="Myriad.Sdk" Version="0.8.3" PrivateAssets="all" /> | ||
| <ProjectReference Include="..\WoofWare.Myriad.Plugins\WoofWare.Myriad.Plugins.fsproj" PrivateAssets="all" WhippetPlugin="true" /> |
There was a problem hiding this comment.
Now all you need to do is add WhippetPlugin="true" and that's all the plugin registration done.
Smaug123
commented
Oct 6, 2024
| @@ -47,6 +47,7 @@ | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1"/> | |||
| <PackageReference Include="NUnit" Version="4.2.2"/> | |||
| <PackageReference Include="NUnit3TestAdapter" Version="4.6.0"/> | |||
| <PackageReference Include="RestEase" Version="1.6.4"/> | |||
There was a problem hiding this comment.
Dunno why this transitive reference became required.
Smaug123
commented
Oct 6, 2024
| interface IMyriadGenerator with | ||
| member _.ValidInputExtensions = [ ".fs" ] | ||
| interface IGenerateRawFromRaw with | ||
| member _.GenerateRawFromRaw (context : RawSourceGenerationArgs) = |
There was a problem hiding this comment.
This is the most basic API on which all other APIs are built. I intend adding optional convenience APIs on top, eventually, but this API shape is how we get the most modular design (which e.g. allows the consumer to freely upgrade Fantomas).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof-of-concept of what it looks like to use Whippet instead of Myriad.