Fetch less in workflows page #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Optimize workflows page by passing `workflow` object directly to `WorkflowActions` to reduce unnecessary data fetching. > > - **Behavior**: > - `WorkflowActions` now receives `workflow` object directly instead of fetching it using `useWorkflowQuery`. > - `deleteWorkflowMutation` in `WorkflowActions.tsx` now uses `workflow.workflow_permanent_id` instead of `id`. > - **Imports**: > - Removed `useWorkflowQuery` import from `WorkflowActions.tsx`. > - Moved `WorkflowApiResponse` and `WorkflowRunApiResponse` imports in `Workflows.tsx` for consistency. > - **Props**: > - Changed `WorkflowActions` prop from `id` to `workflow` in `Workflows.tsx`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for f29cdccd47b33114d03b58b650cb8d016c178947. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ae8ba96 in 18 seconds
More details
- Looked at
68lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowActions.tsx:34
- Draft comment:
TheuseWorkflowQueryimport is still present but should be removed as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_00pXzHJrNO3fXfDE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ae8ba96 in 28 seconds
More details
- Looked at
68lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowActions.tsx:34
- Draft comment:
TheuseWorkflowQueryimport should be removed as it is no longer used. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_tbrAZDz8iYrQ5vUJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Optimize workflows page by passing
workflowobject directly toWorkflowActionsto reduce unnecessary data fetching.WorkflowActionsnow receivesworkflowobject directly instead of fetching it usinguseWorkflowQuery.deleteWorkflowMutationinWorkflowActions.tsxnow usesworkflow.workflow_permanent_idinstead ofid.useWorkflowQueryimport fromWorkflowActions.tsx.WorkflowApiResponseandWorkflowRunApiResponseimports inWorkflows.tsxfor consistency.WorkflowActionsprop fromidtoworkflowinWorkflows.tsx.This description was created by
for ae8ba96. It will automatically update as commits are pushed.