stop retrying steps when decisive action failed

[LawyZheng]

Important

Add warning log for failed DecisiveAction in agent_step() in agent.py when execution continues.

• Logging:
  • Add warning log in agent_step() in agent.py for failed DecisiveAction that does not stop execution.

^{This description was created by for a5a4f2a. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to ba04b71 in 17 seconds

More details

• Looked at 22 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/agent.py:801

• Draft comment:
  The log message for a failed DecisiveAction should indicate that execution will stop, not continue. Consider updating the message to reflect this.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment appears to be incorrect because the code is intentionally logging that execution will not stop after a DecisiveAction fails. The log message aligns with the code's logic, so no change is needed. The comment misunderstands the code's behavior.
  I might be missing some context about the expected behavior of DecisiveAction. However, based on the code, the log message is consistent with the logic implemented.
  The code explicitly logs that execution will not stop, which suggests that this is the intended behavior. The comment seems to misinterpret the code's logic.
  The comment should be deleted because it incorrectly suggests a change to the log message that is consistent with the code's logic.

Workflow ID: wflow_Cn7ib9XBlG31oyIo

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on a5a4f2a in 10 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/agent.py:801

• Draft comment:
  Consider providing more context in the log message for a failed DecisiveAction. It should explain why execution is not stopped or retried, which can help in debugging.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The log message for a failed DecisiveAction is not very informative. It should provide more context about why the execution is not stopped or retried.

Workflow ID: wflow_NrE3tLrSgFnDKnea

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.