Fall back to English plural rules instead of crashing on unknown locale #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For many languages this will already be correct and for the ones that needs a custom configuration, at least it won't crash anymore.
jacobras
commented
Jan 9, 2024
| @@ -73,7 +73,7 @@ object PluralRules { | |||
| "uk" -> Ukrainian | |||
| "kk" -> Kazakh | |||
| "fr" -> French | |||
| else -> custom[languageCode] ?: error("Plural rule for '$languageCode' not provided") | |||
| else -> custom[languageCode] ?: English | |||
There was a problem hiding this comment.
I would like to add some logging here, but there's no logging mechanism in the library currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the library crashes on JS when using any language that doesn't have a set of
PluralRules. See #53.They should be added when needed, but I suggest not crashing on it. It's better to fall back to the English formatting rule. For many languages this will already be correct and the ones that need something else should get a custom configuration.
I would like to add some logging still when the fallback is triggered, but there's no logging mechanism in Libres currently so that's omitted.