[3.0] Some string recasts needed for exports #8342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #8244 , I found two minor unrelated issues with the export. This PR addresses both.
When requesting html exports, the task would hang, leaving this in the PHP error log, and an entry in background_tasks:
When requesting xml exports, the task would appear to complete, and generate an export file for download, but when you opened the export it contained this:
Tested in 3.0 with current GH code, both test OK.