Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: feat: 🌟 dynamic swipe; handle chat prev and next message; currentContext in ChatController; detect more emojis #187

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jonasbadstuebner
Copy link
Contributor

Description

Features:

Chores:

  • I fixed a typo that was annoying me (sentBy is the correct past tense)

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

Migration instructions

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

closes #186

@jonasbadstuebner jonasbadstuebner marked this pull request as draft June 12, 2024 18:05
@jonasbadstuebner
Copy link
Contributor Author

I will add the examples and docs and complete the PR description afterwards.
I will also test if the code works after each commit.

The draft is for you to already look at it and give feedback if you already have any. @vatsaltanna-simformsolutions

The TextDelegate feature is going to be a seperate PR, if you want me to do that and allow your users to add translations.

@jonasbadstuebner
Copy link
Contributor Author

I did not separate the changes, I will do that later, if you want me to. (I think it is better?)

@jonasbadstuebner
Copy link
Contributor Author

The commits are "working" individually in the sense that they build and the example app can be started. However I seem to have made a mistake when moving my changes to the reply to ... Widget and it has a pixel overflow. This could be split out into it's own PR, but I don't have the time to do that right now.

I will look into it at the beginning of next week, please wait with the 2.0.0 release. I don't want to rush the changes now.

@vatsaltanna-simformsolutions
Copy link
Collaborator

updated the current user as well in this pr #190

@jonasbadstuebner jonasbadstuebner force-pushed the merge-upstream branch 2 times, most recently from 87164d3 to 4fee3fa Compare June 14, 2024 10:20
@jonasbadstuebner
Copy link
Contributor Author

I added skin tone detection.

@vatsaltanna-simformsolutions
Copy link
Collaborator

Hi @jonasbadstuebner,

Thank you for the PR. Could you please split this PR into separate ones for each change? I have already created two PRs for sentBy parameter changes and current user changes so you can ignore those changes.

@jonasbadstuebner
Copy link
Contributor Author

Yes, I will do that next week.
It’s complicated, because the changes kind of rely on each other and I don’t have the time to do it on the weekend.

@jonasbadstuebner
Copy link
Contributor Author

I will continue splitting the other commits up tomorrow. Please start reviewing and merging the PRs I already opened. So I don't have to do too much merging work.

They are all tested to be working after each commit, but please double check, since it is very late where I live.

And give me feedback of course.

@vatsaltanna-simformsolutions
Copy link
Collaborator

Hi, @jonasbadstuebner, Are there any changes still required for this PR to be separated or we can close this ?

@jonasbadstuebner
Copy link
Contributor Author

There is more, I will close this PR when I opened all that I wanted to separate from my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wait with 2.0.0 release please
2 participants