-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: feat: 🌟 dynamic swipe; handle chat prev and next message; currentContext in ChatController; detect more emojis #187
base: main
Are you sure you want to change the base?
Conversation
I will add the examples and docs and complete the PR description afterwards. The draft is for you to already look at it and give feedback if you already have any. @vatsaltanna-simformsolutions The |
I did not separate the changes, I will do that later, if you want me to. (I think it is better?) |
The commits are "working" individually in the sense that they build and the example app can be started. However I seem to have made a mistake when moving my changes to the I will look into it at the beginning of next week, please wait with the 2.0.0 release. I don't want to rush the changes now. |
updated the current user as well in this pr #190 |
87164d3
to
4fee3fa
Compare
I added skin tone detection. |
4fee3fa
to
4e3e67b
Compare
Thank you for the PR. Could you please split this PR into separate ones for each change? I have already created two PRs for sentBy parameter changes and current user changes so you can ignore those changes. |
Yes, I will do that next week. |
perf: improve chat swipe performance; less null in configs
4e3e67b
to
f2f6769
Compare
I will continue splitting the other commits up tomorrow. Please start reviewing and merging the PRs I already opened. So I don't have to do too much merging work. They are all tested to be working after each commit, but please double check, since it is very late where I live. And give me feedback of course. |
Hi, @jonasbadstuebner, Are there any changes still required for this PR to be separated or we can close this ? |
There is more, I will close this PR when I opened all that I wanted to separate from my changes. |
Description
Features:
Chores:
sentBy
is the correct past tense)Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Migration instructions
Related Issues
closes #186