Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary Conditions (outlets) to Reimplement and Test #22

Open
1 of 49 tasks
caseyfleeter opened this issue Feb 1, 2018 · 0 comments
Open
1 of 49 tasks

Boundary Conditions (outlets) to Reimplement and Test #22

caseyfleeter opened this issue Feb 1, 2018 · 0 comments
Labels
enhancement New feature or request testing

Comments

@caseyfleeter
Copy link
Collaborator

caseyfleeter commented Feb 1, 2018

These outlet boundary conditions were originally available with the code, but they have not been tested so they were removed from the codebase. They could be reintegrated into the code but would need to be tested. After verifying the formulation gives correct results, Travis test cases would need to generated for the future.

Code re-integration: see commit 1e299f1 for the last instance with the following boundary conditions included. Note that code snippets will need to be copied from this commit and reintegrated manually, as there has been significant restructuring to the codebase that prevents a merge commit.

Regarding Travis: Run automatic test cases and compare them to analytical or numerical solutions (on Travis). Create a minimal test case for each feature of the solver and compare it to a previously computed solution. Whenever possible, use analytical solutions as a comparison.
Please modify the following lists accordingly:

  • add missing features
  • strikethrough removed features
  • check tested features

Reimplemented into code:

Some of these require the following datatables, which also need to be tested:

  • IMPEDANCE.
  • RCRIMPEDANCE.
  • MORPHIMPEDANCE.
  • ADMITTANCE.
  • RCRADMITTANCE.
  • MORPHADMITTANCE.

Analytical/numerical solution generated:

Datatables:

  • IMPEDANCE.
  • RCRIMPEDANCE.
  • MORPHIMPEDANCE.
  • ADMITTANCE.
  • RCRADMITTANCE.
  • MORPHADMITTANCE.

Travis test case(s) added:

Datatables:

  • IMPEDANCE.
  • RCRIMPEDANCE.
  • MORPHIMPEDANCE.
  • ADMITTANCE.
  • RCRADMITTANCE.
  • MORPHADMITTANCE.
@caseyfleeter caseyfleeter added bug Something isn't working enhancement New feature or request question Further information is requested testing labels Feb 1, 2018
@caseyfleeter caseyfleeter mentioned this issue Feb 1, 2018
4 tasks
@caseyfleeter caseyfleeter removed bug Something isn't working question Further information is requested labels Jun 1, 2020
@caseyfleeter caseyfleeter changed the title Test Functionality of Boundary Condition Implementations Boundary Condition to Reimplementations Jun 1, 2020
@caseyfleeter caseyfleeter changed the title Boundary Condition to Reimplementations Boundary Condition to Reimplement and Test Jun 1, 2020
@caseyfleeter caseyfleeter changed the title Boundary Condition to Reimplement and Test Boundary Conditions (outlets) to Reimplement and Test Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

1 participant