Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Broken test cases #8

Closed
4 tasks
caseyfleeter opened this issue Feb 1, 2018 · 0 comments
Closed
4 tasks

FIX Broken test cases #8

caseyfleeter opened this issue Feb 1, 2018 · 0 comments
Labels
bug Something isn't working testing

Comments

@caseyfleeter
Copy link
Collaborator

caseyfleeter commented Feb 1, 2018

There are 4 broken test cases which need to be repaired:

  • Case 06: The has a segmentation fault, potentially because the IMPEDANCE boundary conditions aren't properly implemented? (see issue Boundary Conditions (outlets) to Reimplement and Test #22 )
  • Case 07: Invalid datable type "WAVE". This is currently working with type "LIST" for the WAVETABLE, but we should check the WAVE boundary condition as well. (see issue Boundary Conditions (outlets) to Reimplement and Test #22 )
  • Case 08: Area goes negative (check_pos() fails). This means the area of a segmentation is negative. The amount of pressure in the model may not be high enough, so the R BC should be changed.
  • Case 15: Area goes negative (check_pos() fails). This means the area of a segmentation is negative. Number of finite elements/segment may need adjustments.
@caseyfleeter caseyfleeter added bug Something isn't working testing labels Feb 1, 2018
This was referenced Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

No branches or pull requests

1 participant