CG and BICG implementation for all equations #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrp089
requested changes
Sep 12, 2023
tests/cases/niederer_benchmark_ECGs_quadrature/svFSI_GMRES_FE_pfib_AP.xml
Outdated
Show resolved
Hide resolved
mrp089
reviewed
Sep 13, 2023
ktbolt
approved these changes
Sep 13, 2023
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* CG for vectors * BICG for vectors * Add new tests for 3D CEP: (CG, BICG, GMRES), (epi, endo, myo), (AP, BO, TTP) * Remove ECGs + typo * Relative errors for ECGs + error message
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* CG for vectors * BICG for vectors * Add new tests for 3D CEP: (CG, BICG, GMRES), (epi, endo, myo), (AP, BO, TTP) * Remove ECGs + typo * Relative errors for ECGs + error message
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* CG for vectors * BICG for vectors * Add new tests for 3D CEP: (CG, BICG, GMRES), (epi, endo, myo), (AP, BO, TTP) * Remove ECGs + typo * Relative errors for ECGs + error message
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* CG for vectors * BICG for vectors * Add new tests for 3D CEP: (CG, BICG, GMRES), (epi, endo, myo), (AP, BO, TTP) * Remove ECGs + typo * Relative errors for ECGs + error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR solves issue #90, where I noticed that CG and BICG were not implemented for CEP.
I translated the corresponding Fortran code so that CG and BICG are now available for all equations and physics.
I added 4 test cases from 3D CEP to test the different linear solvers (CG, BICG, GMRES), cardiac cells (epicardium, myocardium, endocardium) and ionic models (AP, BO, TTP).
@ktbolt and @mrp089, I am ready for your review!