Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a compilation erro with Trilino in shell.cpp #81

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix a compilation erro with Trilino in shell.cpp #81

merged 2 commits into from
Aug 9, 2023

Conversation

wgyang
Copy link
Contributor

@wgyang wgyang commented Aug 9, 2023

For issue #82, add the header file and modify the input for trilinos_doassem_ in shells.cpp so the code can be compiled with Trilino.

Weiguang Yang and others added 2 commits August 9, 2023 13:37
@ktbolt
Copy link
Collaborator

ktbolt commented Aug 9, 2023

@wgyang All modifications to the code need to have an Issue created for it. Issues create a clear history of code modifications and lets developers communicate about bugs, enhancements, etc.

@wgyang
Copy link
Contributor Author

wgyang commented Aug 9, 2023

I have created an issue and referenced this pull request to the corresponding issue number.

@ktbolt
Copy link
Collaborator

ktbolt commented Aug 9, 2023

Super!

@ktbolt ktbolt self-requested a review August 9, 2023 23:26
@ktbolt ktbolt merged commit 17b4f7d into SimVascular:main Aug 9, 2023
3 checks passed
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
…os_doassem_ and added a header file within shell.cpp (#81)

Co-authored-by: Weiguang Yang <[email protected]>
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
…os_doassem_ and added a header file within shell.cpp (#81)

Co-authored-by: Weiguang Yang <[email protected]>
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
…os_doassem_ and added a header file within shell.cpp (#81)

Co-authored-by: Weiguang Yang <[email protected]>
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
…os_doassem_ and added a header file within shell.cpp (#81)

Co-authored-by: Weiguang Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants