Holzapfel Ogden Modified Anisotropy (HO-ma) Constitutive Model

[divyaadil23]

Same as the previous pull request, but the commits have been squashed into one.

Current situation

#249

Release Notes

• Added the Holzapfel Ogden Modified Anisotropy (HO-ma) Constitutive Model to material models.
• Updated Holzapfel Ogden Model.
• Both HO and HO-ma models are taken from https://github.com/vvedula22/svFSI/blob/master/Code/Source/svFSI/MATMODELS.f and modified. Added additional terms containing the second derivative of smoothed heaviside funciton to the elasticity tensor to make it exact. Changed the approximate derivatives of heaviside function to exact. Removed fds (dot product of fiber directions in 8th invariant).
• Tested it with the new framework of unit tests - the unit tests now test the order of convergence for finite difference estimates.
• Added some integrated tests for struct and ustruct for both models.

Documentation

Where can I document how to use the new material model? Also, should I add the derivation?

Testing

Added 4 integration tests for HO and HO-ma models. Added new unit tests for both.

Code of Conduct & Contributing Guidelines

• I agree to follow the Code of Conduct and Contributing Guidelines.

[aabrown100-git]

Looks like in your most recent commit (merging SimVascular::main), your new tests failed. I think you might just have to rename your new test input files from svFSI.xml to svFSIplus.xml.

[aabrown100-git]

All looks good to me!

[aabrown100-git]

Looks like your HO and HO-ma integration tests failed. It's probably because the reference solutions were generated with the default solid_viscosity value, which was erroneously set to 0.9 previously. The most recent commit changes the default value to 0.0, so the integration tests now use a solid_viscosity value of 0.0.

You can verify this by setting the solid_viscosity parameter to 0.9 in your test input files
<Solid_viscosity> 0.9 </Solid_viscosity>
The tests should pass. If so, I think you can just rerun your tests with 0 solid viscosity (just delete it from the input file) and update your reference solution with the result.

[codecov]

Codecov Report

Attention: Patch coverage is 85.24845% with 95 lines in your changes missing coverage. Please review.

Project coverage is 66.38%. Comparing base (82c9ea6) to head (9f79d78).

Files with missing lines	Patch %	Lines
tests/unitTests/test.h	67.49%	92 Missing ⚠️
Code/Source/svFSI/Parameters.cpp	50.00%	2 Missing ⚠️
Code/Source/svFSI/read_files.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   65.67%   66.38%   +0.71%     
==========================================
  Files         116      116              
  Lines       29574    30334     +760     
==========================================
+ Hits        19422    20138     +716     
- Misses      10152    10196      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[divyaadil23]

@ktbolt we have resolved the comments on this pull request. Could you review it again? Thanks!