Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): replace Sia Central with explored API for the host route (minus benchmarks) #819

Conversation

telestrial
Copy link
Contributor

@telestrial telestrial commented Nov 20, 2024

The only snaffu here is that the benchmark aspect of host is not ready yet, so I simply commented it out for now. I'll spawn a task for it.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 6:01pm
explorer-zen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 6:01pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hostd ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 6:01pm
renterd ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 6:01pm
website ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 6:01pm

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 03261a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
explorer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@telestrial telestrial marked this pull request as ready for review November 20, 2024 18:51
@telestrial telestrial force-pushed the 11-19-feat_explored_add_the_hostbypubkey_api branch from f56707a to 8c2b88d Compare November 20, 2024 20:59
@telestrial telestrial force-pushed the 11-20-feat_explorer_replace_sia_central_with_explored_api_for_the_host_route_minus_benchmarks_ branch from 4ca7e50 to 0946cc5 Compare November 20, 2024 20:59
@telestrial telestrial force-pushed the 11-19-feat_explored_add_the_hostbypubkey_api branch from 8c2b88d to d12cf35 Compare November 20, 2024 22:57
@telestrial telestrial force-pushed the 11-20-feat_explorer_replace_sia_central_with_explored_api_for_the_host_route_minus_benchmarks_ branch from 0946cc5 to 49d8730 Compare November 20, 2024 22:57
@telestrial telestrial force-pushed the 11-19-feat_explored_add_the_hostbypubkey_api branch from d12cf35 to 37ebce5 Compare November 20, 2024 22:59
@telestrial telestrial force-pushed the 11-20-feat_explorer_replace_sia_central_with_explored_api_for_the_host_route_minus_benchmarks_ branch from 49d8730 to 5672d84 Compare November 20, 2024 22:59
Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, did we previously add a basic test?

apps/explorer/components/Host/HostPricing.tsx Show resolved Hide resolved
Copy link
Contributor Author

telestrial commented Nov 21, 2024

Merge activity

  • Nov 21, 12:47 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 21, 12:56 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 21, 12:57 PM EST: A user merged this pull request with Graphite.

@telestrial
Copy link
Contributor Author

lgtm, did we previously add a basic test?

We have e2e tests for all routes on the Explorer now, including host, if that's what you're asking.

@telestrial telestrial changed the base branch from 11-19-feat_explored_add_the_hostbypubkey_api to graphite-base/819 November 21, 2024 17:51
@telestrial telestrial changed the base branch from graphite-base/819 to main November 21, 2024 17:53
@telestrial telestrial force-pushed the 11-20-feat_explorer_replace_sia_central_with_explored_api_for_the_host_route_minus_benchmarks_ branch from 856d6cf to 03261a1 Compare November 21, 2024 17:55
@telestrial telestrial merged commit 5071f9d into main Nov 21, 2024
22 of 33 checks passed
@telestrial telestrial deleted the 11-20-feat_explorer_replace_sia_central_with_explored_api_for_the_host_route_minus_benchmarks_ branch November 21, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants