Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(apps): persist layouts between page transitions #794

Merged
merged 1 commit into from
Oct 28, 2024
Merged

refactor(apps): persist layouts between page transitions #794

merged 1 commit into from
Oct 28, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Oct 24, 2024 •
edited
Loading

  • This PR splits out the "layout" from each page and mounts it and passes its props in _app.tsx instead which allows us to persist (avoid unmounting) components that are the same between page layouts.
  • Until now the current setup has been fine as this remounting is instantaneous and invisible to the user. The following PR adds animations to components in the layout's bottom actions bar which means without this change components that should persist in this actions bar would re-run their animations when tabbing between pages.
  • The LOC in this PR are entirely the boring systematic work of updating every single page entry point in renterd, hostd, and walletd to follow this pattern.

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hostd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:37pm
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:37pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 5:37pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 5:37pm
website ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 5:37pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d934724

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
hostd Patch
renterd Patch
walletd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska alexfreska mentioned this pull request Oct 24, 2024
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska mentioned this pull request Oct 24, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 3a8a307 to 9f70583 Compare October 24, 2024 14:59
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from b98001b to 5242973 Compare October 24, 2024 14:59
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 9f70583 to 6c8467f Compare October 24, 2024 19:51
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 5242973 to a0316dc Compare October 24, 2024 19:51
This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alexfreska alexfreska mentioned this pull request Oct 24, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 6c8467f to c7ee0d9 Compare October 25, 2024 16:47
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from a0316dc to e80566c Compare October 25, 2024 16:47
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from c7ee0d9 to 4a3ca2a Compare October 25, 2024 17:45
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from e80566c to b3d0c9f Compare October 25, 2024 17:45
@alexfreska alexfreska mentioned this pull request Oct 25, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from b3d0c9f to 91b712f Compare October 25, 2024 18:59
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch 2 times, most recently from 5454520 to b8ff760 Compare October 25, 2024 19:36
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 91b712f to 9ec9900 Compare October 25, 2024 19:36
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from b8ff760 to b32b1c7 Compare October 25, 2024 19:43
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 9ec9900 to 41da4e8 Compare October 25, 2024 19:43
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Oct 28, 2024 •
edited
Loading

Merge activity

  • Oct 28, 1:15 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 28, 1:18 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 28, 1:19 PM EDT: A user merged this pull request with Graphite.

@alexfreska alexfreska changed the base branch from refactor_refine_multiselect_api to graphite-base/794 October 28, 2024 17:16
@alexfreska alexfreska changed the base branch from graphite-base/794 to main October 28, 2024 17:16
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 41da4e8 to d934724 Compare October 28, 2024 17:17
@alexfreska alexfreska merged commit e9995c5 into main Oct 28, 2024
10 of 33 checks passed
@alexfreska alexfreska deleted the refactor_apps_persist_layouts_between_page_transitions branch October 28, 2024 17:19
This was referenced Oct 29, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telestrial telestrial telestrial approved these changes

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @telestrial