Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two SiN PCell to Beta Library #309

Merged

Conversation

Hang-Bobby-Zou
Copy link
Contributor

  • Added a slot_SiN.py PCell file for straight slot SiN waveguide since there is no option for SiN in the "path to waveguide" function. THIS IS ONLY TEMPORARY. Will raise issue and added the option once we know the default values from the openEBL-2024-10-SiN run
  • Added a strip_to_slot_SiN.py PCell that allows tapers from a strip/slot with any width/slot width of your choice. Also added functionality for adiabatic taper to avoid any abrupt changes at the tip.

- Added a slot_SiN.py PCell file for straight slot SiN waveguide since there is no option for SiN in the "path to waveguide" function. THIS IS ONLY TEMPORARY. Will raise issue and added the option once we know the default values from the openEBL-2024-10-SiN run
- Added a strip_to_slot_SiN.py PCell that allows tapers from a strip/slot with any width/slot width of your choice. Also added functionality for adiabatic taper to avoid any abrupt changes at the tip.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (d964c34) to head (b405184).

Files with missing lines Patch % Lines
...ayout/EBeam/pymacros/pcells_EBeam_Beta/slot_SiN.py 97.61% 1 Missing ⚠️
...am/pymacros/pcells_EBeam_Beta/strip_to_slot_SiN.py 98.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   73.60%   73.80%   +0.20%     
==========================================
  Files          94       96       +2     
  Lines       11682    11783     +101     
==========================================
+ Hits         8598     8697      +99     
- Misses       3084     3086       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasc-ubc lukasc-ubc merged commit 7319138 into SiEPIC:master Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants