Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecs using paths function #50

Closed
wants to merge 7 commits into from
Closed

Conversation

Hanmac
Copy link
Collaborator

@Hanmac Hanmac commented Oct 21, 2024

Fixes the Failed Test in #49

@Hanmac Hanmac added the bug Something isn't working label Oct 21, 2024
@Hanmac Hanmac requested a review from loevgaard October 21, 2024 15:19
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.62%. Comparing base (3f608de) to head (384dfc2).

Files with missing lines Patch % Lines
src/Doctrine/DBAL/Types/CronExpressionType.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage     98.62%   98.62%           
  Complexity       77       77           
=========================================
  Files             9        9           
  Lines           291      291           
=========================================
  Hits            287      287           
  Misses            4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hanmac
Copy link
Collaborator Author

Hanmac commented Oct 21, 2024

@loevgaard I can't apply PhpCsFixer\Fixer\ControlStructure\TrailingCommaInMultilineFixer without breaking php7.4 support

@or-benjamin same there with the mixed type

Is it time to drop php7.4 support?

@loevgaard
Copy link
Member

It would be great to remove PHP 7.4 support and go to 8.1 :)

@Chris53897
Copy link
Contributor

#51

@Hanmac
Copy link
Collaborator Author

Hanmac commented Oct 23, 2024

Closed in favor of #52

@Hanmac Hanmac closed this Oct 23, 2024
@Hanmac Hanmac deleted the Hanmac-patch-ecs_paths branch October 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants