Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker-compose / make based CI #789

Merged
merged 8 commits into from
Oct 19, 2023
Merged

add docker-compose / make based CI #789

merged 8 commits into from
Oct 19, 2023

Conversation

gesinn-it-evl
Copy link
Contributor

This PR is made in reference to: nothing

This PR addresses or contains:

  • docker-compose based CI
  • test-coverage script in composer.json
  • github-action (ci.yml) that runs phpunit

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #789 (584e1b4) into master (71822ed) will increase coverage by 0.18%.
Report is 65 commits behind head on master.
The diff coverage is 42.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #789      +/-   ##
============================================
+ Coverage     40.35%   40.54%   +0.18%     
- Complexity     2061     2323     +262     
============================================
  Files            75       78       +3     
  Lines          7268     8231     +963     
============================================
+ Hits           2933     3337     +404     
- Misses         4335     4894     +559     
Files Coverage Δ
SemanticResultFormats.hooks.php 0.00% <ø> (ø)
formats/filtered/src/Filtered.php 93.90% <100.00%> (+0.07%) ⬆️
formats/gallery/Gallery.php 94.88% <100.00%> (ø)
formats/slideshow/SRF_SlideShow.php 0.00% <ø> (ø)
src/Graph/GraphOptions.php 95.45% <100.00%> (ø)
formats/datatables/Hooks.php 96.87% <96.87%> (ø)
src/ResourceFormatter.php 97.43% <90.00%> (-2.57%) ⬇️
formats/jqplot/SRF_jqPlot.php 0.00% <0.00%> (ø)
formats/carousel/Carousel.php 91.27% <91.27%> (ø)
formats/datatables/Api.php 0.00% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gesinn-it-evl gesinn-it-evl merged commit adf13b5 into master Oct 19, 2023
3 of 4 checks passed
@JeroenDeDauw
Copy link
Member

Now the tests on master fail. Better to either remove the 1.40 tests or to make them optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants