-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cobol lexer eol #284
base: master
Are you sure you want to change the base?
Cobol lexer eol #284
Conversation
Updated Cobol Lexer to respect EOL Styles
Use consistent code styling and whitespace in file.
Update AllStyles Test to include EOL Style Test Ran astyle on LexCOBOL.cxx to format file properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the whitespace changes on the first commit! Recommend hiding whitespace to see the actual code changes for this styling on this one commit. The next commits clean up whitespace issues so you can turn on view whitespace to review those commits
It's unclear just what this change is trying to do. The Reformatting the code makes it more difficult to understand the functional change and isn't needed. |
Hmm I see. The intent here is to style EOL Terminators for the language. C++ ends a statement with semi-colon ; But it looks like that's not how SCE_C_STRINGEOL is used for C in the way we are using it for a terminating statement character in COBOL. Open to recommendations. If a new Style set is needed, that might be too much work for me to do for the Current Cobol Lexer at this time. I'm not sure who the original author for it was, we've been using a modified version of the Lexer for years since ScintillaNET 2.0 lol Was hoping to get this change in so it's a permanent part of the Lexer and our editor. I am just upgrading things to the latest versions (Scintilla.NET 5.6.1, etc.) |
Most lexers treat terminators as operators so they are styled the same. There are benefits to enhancing the visibility of terminators but adding a new lexical class will make COBOL behave differently to other lexers in a way that applications, themes, and users won't be expecting. |
…COBOL. Include C++ headers, use unnamed namespace instead of static, remove inline, use nullptr. Related to #284.
…OBOL lexers reuse of the SCE_C_* constants defined for the cpp lexer. The values are the same to provide binary compatibility. Related to #284.
…s, just the 3rd set of keywords or known identifiers. The value remains the same, 8. Related to #284.
Changed the COBOL lexer to use its own named style constants |
Allows Cobol Lexer to respect Style 12 for EOL terminators (such as period in COBOL)