Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version #151

Merged
merged 5 commits into from
Feb 17, 2023
Merged

New version #151

merged 5 commits into from
Feb 17, 2023

Conversation

iliailmer
Copy link
Collaborator

This version would support Groebner.jl v0.3 in SIAN (alexeyovchinnikov/SIAN-Julia#81)

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #151 (200d1f5) into master (0f6757e) will increase coverage by 20.70%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #151       +/-   ##
===========================================
+ Coverage   67.76%   88.46%   +20.70%     
===========================================
  Files          14       14               
  Lines        1821     1830        +9     
===========================================
+ Hits         1234     1619      +385     
+ Misses        587      211      -376     
Impacted Files Coverage Δ
src/global_identifiability.jl 69.67% <0.00%> (+2.58%) ⬆️
src/ODE.jl 96.61% <0.00%> (+9.42%) ⬆️
src/power_series_utils.jl 99.15% <0.00%> (+10.08%) ⬆️
src/elimination.jl 97.71% <0.00%> (+10.95%) ⬆️
src/local_identifiability.jl 99.00% <0.00%> (+12.93%) ⬆️
src/StructuralIdentifiability.jl 94.11% <0.00%> (+13.72%) ⬆️
src/util.jl 93.33% <0.00%> (+36.11%) ⬆️
src/io_equation.jl 96.66% <0.00%> (+37.23%) ⬆️
src/pb_representation.jl 97.61% <0.00%> (+97.61%) ⬆️
src/lincomp.jl 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pogudingleb
Copy link
Collaborator

What is the relation to SIAN? Isn't this just merging the compute PR?

@iliailmer
Copy link
Collaborator Author

SIAN cannot use Groebner 0.3 until StructuralIdentifiability supports it.

@pogudingleb pogudingleb merged commit 3b705b9 into SciML:master Feb 17, 2023
@pogudingleb
Copy link
Collaborator

@iliailmer Feel free to register a version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants