❇️ Re-implementation of plugins API #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new design of the plugins API. The classes are now in the new library
Yarhl.Plugins
. This implementation does not use any underlying technology like MEF in the past.There are two main classes:
TypeLocator
: it scans the current loaded assemblies to find types that implement the given interface.ConverterLocator
usingTypeLocator
keeps a cache of types and converters found in assemblies.Additionally, new extension methods for
AssemblyLoadContext
help to load assemblies from the current executing directory or a given path. By default it does not load any additional assembly from any folder anymore. This was a potential security risk. Developers can choose to do it via these extension methods, alerting the user first if wanted.Quality check list
developer certificate of origin
Acceptance criteria
Follow-up work
None
Example