Fix: Enable API_SERVER
injection in netlify build
#49
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1: 再現済み環境
Step 2: 変更内容
REACT_APP_STAGING_BUILD
がtruthyならば、NODE_ENV
がdevelopment
ではなくてもAPI_SERVER
をCookie経由で変更することを許可するREACT_APP_STAGING_BUILD
をセットするStep 2: 検証手順
再現のための手順:
(検証前に
yarn global add serve
)yarn build
serve build
で開くので、API_SERVER
をCookieからつけてもリクエスト先が変わっていないことを確認するserve build
で開くので、API_SERVER
をCookieからつけるとリクエスト先が変わっていることを確認する修正前の挙動:
yarn build
するとAPI_SERVER
をCookieからつけてもリクエスト先が変わらない修正後の挙動:
REACT_APP_STAGINIG_BUILD=1
なら、yarn build
でもAPI_SERVER
をCookieからつけてリクエスト先が変わるStep 3: 影響範囲