Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed units of current from statA to A #209

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

nickishch
Copy link
Collaborator

Changed current units (because for MHD we use A current units, not statA)

@nickishch nickishch added the enhancement New feature or request label Oct 15, 2024
@JBorrow
Copy link
Member

JBorrow commented Oct 15, 2024

And this resolves all your problems?

@nickishch
Copy link
Collaborator Author

nickishch commented Oct 15, 2024

And this resolves all your problems?

yes, at least it agrees with what snapshots show us

  1. in snapshots the conversion factor to CGS ( units of g/(A s^2) ) is 2e-6 for the runs I had (as on the screenshot)
  2. opening the same snapshot in swiftsimio with the fix gives magnetic fields in units 1e-6 Msun /(A Gyr^2), and this converts to 2e-6 g/(A s^2), this agrees with the snapshots

Though there is some Issue when converting g/(A s^2) to Gauss. unyt says that for some reason 1 gauss = 1 cm^0.5⋅g^0.5⋅s^−1 but on wikipedia we also can find that 1 gauss is 0.1 g/(A s^2) or 10^-4 kg/(A s^2) as they say
https://en.wikipedia.org/wiki/Gauss_(unit).
In practice multiplying the result in g/(A s^2) units by 10 gives MF in gauss, so I don't know if we need to devote a lot of time to this issue, how do you think?

Screenshot 2024-10-11 at 13 35 42

@JBorrow JBorrow merged commit 2b5ea76 into master Oct 15, 2024
7 checks passed
@JBorrow
Copy link
Member

JBorrow commented Oct 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants