Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THUB-19: basic card styling #12

Merged
merged 3 commits into from
Jul 1, 2024
Merged

THUB-19: basic card styling #12

merged 3 commits into from
Jul 1, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Jun 27, 2024

READY FOR REVIEW

Summary

  • Changed the styles for a basic card.

Review By (Date)

  • 6/30

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Create a new page.
  3. Add some cards.
  4. Verify they look like the design.
  5. Designs linked in the ticket.
  6. Can you look at the images to make sure they aren't distorted by the resizing in css?

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- THUB-19

Resources

@jenbreese jenbreese changed the title Thub 19 basic card THUB-19: basic card styling Jun 27, 2024

margin-bottom: 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jenbreese everything looks great! It looks like all we're missing is the spacing for the <p> tags. We could add a margin-bottom to the heading and add a margin-bottom to the last <p> tag 😄 Let me know what you think!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebeccahongsf I added margins to the <p> because headings can be optional. Thank you for catching this!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jenbreese! This looks good to me 🎉

Feel free to merge it in when you're ready since I pre-approved 😄

@jenbreese jenbreese merged commit 5d560b6 into 1.x Jul 1, 2024
1 check passed
@jenbreese jenbreese deleted the THUB-19--basic-card branch July 1, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants