Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: v4.0.8 #373

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Release: v4.0.8 #373

merged 2 commits into from
Aug 30, 2023

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Aug 30, 2023

Release v4.0.8

Summary

  • name browserslistrc properly
  • Add SR only label to search field; add type="button" to buttons
  • Add type="button" for all the buttons missing this attribute
  • a11y patch ups
  • Add aria live to number of search results
  • Pagination improvements
  • Return focus to open search button after search overlay is closed
  • Fix for document not available during SSR
  • Add underline on highlighted suggested search; use ul for search results structure
  • Remove redundant role=navigation on pagination# NOT READY FOR REVIEW

su-sws-jira and others added 2 commits August 1, 2023 15:36
* name browserslistrc properly

* Add SR only label to search field; add type="button" to buttons

* Add type="button" for all the buttons missing this attribute

* a11y patch ups

* fixups

* Add aria live to number of search results

* Pagination improvements

* Return focus to open search button after search overlay is closed

* Fix for document not available during SSR

* Add underline on highlighted suggested search; use ul for search results structure

* Remove redundant role=navigation on pagination
@sherakama sherakama added the patch patch label Aug 30, 2023
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sherakama! I'll work on the rest this sprint 😄

@sherakama sherakama merged commit 7f1c0e8 into main Aug 30, 2023
2 checks passed
@sherakama sherakama deleted the release/v4.0.8 branch August 30, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants