Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-834: Hide non-display paragraphs values in Layout Paragraphs preview #428

Merged
merged 4 commits into from
May 24, 2024

Conversation

joegl
Copy link
Collaborator

@joegl joegl commented May 8, 2024

READY FOR REVIEW

Summary

  • Added a preview_paragraphs SCSS and CSS files with yarn compiling to sdss_layout_paragraphs
  • Added SCSS to hide the BG Color and Font Size values in the paragraph preview.

Review By (Date)

5/22

Criticality

4

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Create a new News article
  3. Add a single column layout with a Callout Quote paragraph
  4. Verify the bg color and font sizing field values are no longer displayed in the preview

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

https://stanfordits.atlassian.net/browse/SDSS-834

Resources

@joegl joegl requested a review from jenbreese May 8, 2024 16:39
@joegl joegl changed the title SDSS-834: Hide callout paragraph values in Layout Paragraphs preview SDSS-834: Hide non-display paragraphs values in Layout Paragraphs preview May 9, 2024
@joegl
Copy link
Collaborator Author

joegl commented May 9, 2024

@jenbreese I've updated to hide the editorial sidebar fields per your suggestion (thanks) -- this is ready for review again.

Copy link
Contributor

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GtG. Thanks for updating the webpack. I tried that too.

@joegl joegl merged commit 86633bf into 4.x May 24, 2024
5 checks passed
@joegl joegl deleted the SDSS-834--hide-callout-values-wysiwyg branch May 24, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants