Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-478: Fix to the wysiwyg spacing with section background colors #421

Merged
merged 6 commits into from
May 17, 2024

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Apr 23, 2024

READY FOR REVIEW

Summary

  • Padding on the wysiwyg
  • Done for the row colors and not.

Review By (Date)

  • soon

Criticality

  • Low

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a page and create some content with a colored rows background. Use this page as an example for the bullets - https://sdssuserguide-prod.stanford.edu/start-here/best-practices/links-buttons/jump-links
  3. Verify the content isn't up on the edge.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-478

Resources

@jenbreese jenbreese changed the title SDSS-478: fixes to the wysiwyg with background colors SDSS-478: Fix to the wysiwyg spacing with section background colors Apr 26, 2024
@github-actions github-actions bot added the patch label May 8, 2024
@jenbreese
Copy link
Contributor Author

@jdwjdwjdw This is ready for you to review. I updated the amount of padding per design.

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jenbreese

@jenbreese
Copy link
Contributor Author

5/9/2024: We are in a code freeze until next deployment on the 15th. No merging until after the 15th.

@github-actions github-actions bot removed the patch label May 17, 2024
@jenbreese jenbreese merged commit 3a2cc46 into 4.x May 17, 2024
5 checks passed
@jenbreese jenbreese deleted the SDSS-478--padding branch May 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants