Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-823: Added bottom margin to News nodes to add space before footer. #199

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • soon - would like in the MVP release

Criticality

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a news article
  3. Verify there is MS(4) margin above local footer.
  4. Navigate to another page.
  5. Verify there is no change.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-823

Resources

@joegl joegl changed the title SDSS-823: adding margin before footer SDSS-823: Added bottom margin to news node to add space before footer. Aug 2, 2023
@joegl joegl changed the title SDSS-823: Added bottom margin to news node to add space before footer. SDSS-823: Added bottom margin to News nodes to add space before footer. Aug 2, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jen!

@joegl joegl merged commit 305180a into feature/newsroom-layout-paragraphs Aug 2, 2023
4 checks passed
@joegl joegl deleted the SDSS-823--footer-margin branch August 2, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants