Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5911: Add indicator of 3rd level shortcut menu #1681

Merged

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Nov 7, 2024

READY FOR REVIEW

Summary

Adds indicator of shortcut menu 3rd level

Need Review By (Date)

11/20

Urgency

'medium

Steps to Test

  1. In any site, go to this path: /admin/config/user-interface/shortcut/manage/default/customize
  2. Add a shortcut item as a third level item
  3. Now verify that if there are 3rd-level items, they have an indicator that let the user knows there's a 3rd level menu item
  4. You can check an existing 3rd-level link here: https://pr1681-drxb2zpp0vmpul1acmcab6mkcz95fral.tugboatqa.com/ (Shortcuts > Site Actions > Page not found Report > Third level)

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat November 7, 2024 00:13 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 7, 2024 00:34 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 7, 2024 00:48 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 7, 2024 19:56 Destroyed
Base automatically changed from 11.5.1-release to develop November 13, 2024 15:35
@cienvaras cienvaras changed the base branch from develop to 11.5.2-release November 13, 2024 16:56
…-5911--add-indicator-of-shortcut-menu-3rd-level
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks great, but the indicator is only present on the FE theme. If I visit an admin page (e.g. /admin/content) the indicator is absent. You need to also add the styles in the admin theme.

@ahughes3 ahughes3 temporarily deployed to Tugboat November 13, 2024 17:10 Destroyed
Mari Nez added 2 commits November 13, 2024 13:46
…github.com:SU-HSDO/suhumsci into shs-5911--add-indicator-of-shortcut-menu-3rd-level
@ahughes3 ahughes3 temporarily deployed to Tugboat November 13, 2024 19:54 Destroyed
@mariannuar
Copy link
Collaborator Author

@cienvaras Ready for review again. Visit https://pr1681-drxb2zpp0vmpul1acmcab6mkcz95fral.tugboatqa.com/ and check for Shortcuts > Site Actions > Page not found Report > Third level

Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Left a question for you.

@ahughes3 ahughes3 temporarily deployed to Tugboat November 14, 2024 17:28 Destroyed
@mariannuar
Copy link
Collaborator Author

@cienvaras
Copy link
Collaborator

@mariannuar LGTM! 🚀

@ahughes3 Ready for your review.

@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Nov 14, 2024
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariannuar
Copy link
Collaborator Author

Hi @joegl can we please hold on the merge of this PR? My local environment is not working right now, and I would like to use the tugboat preview of this PR for today's demo. Thanks!

@joegl
Copy link
Contributor

joegl commented Nov 19, 2024

Hi @joegl can we please hold on the merge of this PR? My local environment is not working right now, and I would like to use the tugboat preview of this PR for today's demo. Thanks!

No problem @mariannuar ! Let me know once it's ready again and hope the demo goes great 👍

@mariannuar
Copy link
Collaborator Author

@joegl Thank you! It's ready again. 🙂

Base automatically changed from 11.5.2-release to develop November 20, 2024 16:11
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Nov 20, 2024
@ahughes3 ahughes3 requested a review from joegl November 20, 2024 17:45
@joegl joegl changed the base branch from develop to 11.6.1-release November 22, 2024 15:35
@joegl joegl merged commit 8d192e5 into 11.6.1-release Nov 22, 2024
16 checks passed
@joegl joegl deleted the shs-5911--add-indicator-of-shortcut-menu-3rd-level branch November 22, 2024 15:36
@joegl joegl changed the title SHS-5911: Indicator of shortcut menu 3rd level SHS-5911: Add indicator of 3rd level shortcut menu Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants