-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5911: Add indicator of 3rd level shortcut menu #1681
SHS-5911: Add indicator of 3rd level shortcut menu #1681
Conversation
…-5911--add-indicator-of-shortcut-menu-3rd-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Looks great, but the indicator is only present on the FE theme. If I visit an admin page (e.g. /admin/content
) the indicator is absent. You need to also add the styles in the admin theme.
…github.com:SU-HSDO/suhumsci into shs-5911--add-indicator-of-shortcut-menu-3rd-level
@cienvaras Ready for review again. Visit https://pr1681-drxb2zpp0vmpul1acmcab6mkcz95fral.tugboatqa.com/ and check for Shortcuts > Site Actions > Page not found Report > Third level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Left a question for you.
docroot/themes/humsci/su_humsci_gin_admin/dist/su_humsci_gin_admin.css
Outdated
Show resolved
Hide resolved
@mariannuar LGTM! 🚀 @ahughes3 Ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @joegl can we please hold on the merge of this PR? My local environment is not working right now, and I would like to use the tugboat preview of this PR for today's demo. Thanks! |
No problem @mariannuar ! Let me know once it's ready again and hope the demo goes great 👍 |
@joegl Thank you! It's ready again. 🙂 |
READY FOR REVIEW
Summary
Adds indicator of shortcut menu 3rd level
Need Review By (Date)
11/20
Urgency
'medium
Steps to Test
PR Checklist