Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5885: Remove "Admin Login Path" module #1674

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Oct 30, 2024

READY FOR REVIEW

Summary

  • Remove admin_login_path from project dependencies

Need Review By (Date)

11/06

Urgency

medium

Steps to Test

  1. Log in to the Tugboat test site
  2. Visit the modules admin page, search for "admin login path". Confirm that the module is not available anymore.

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat October 30, 2024 22:10 Destroyed
@cienvaras
Copy link
Collaborator Author

@ahughes3 Ready for you to review.

@ahughes3 ahughes3 temporarily deployed to Tugboat October 30, 2024 22:29 Destroyed
@ahughes3
Copy link
Collaborator

@cienvaras The module appeared when I searched for Admin Login Path

Screenshot 2024-10-30 at 6 03 40 PM

@ahughes3 ahughes3 assigned cienvaras and unassigned ahughes3 Oct 30, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat October 31, 2024 15:44 Destroyed
@cienvaras
Copy link
Collaborator Author

@ahughes3 Sorry about that, I forgot that changing installed modules requires to build the tugboat test site without using a base preview. It's ready for testing again.

@cienvaras cienvaras assigned ahughes3 and unassigned cienvaras Oct 31, 2024
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahughes3 ahughes3 requested a review from joegl October 31, 2024 18:24
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 31, 2024
@joegl joegl merged commit f58b249 into 11.5.1-release Oct 31, 2024
17 checks passed
@joegl joegl deleted the shs-5885--remove-admin-login-path-module branch October 31, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants