Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5881: Adjust views available for use in the developer's catalog #1668

Merged
merged 1 commit into from
Oct 31, 2024
Merged

SHS-5881: Adjust views available for use in the developer's catalog #1668

merged 1 commit into from
Oct 31, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Oct 28, 2024 •
edited by ahughes3
Loading

READY FOR REVIEW

Summary

Remove a list of selected views from the "Developer's Catalog" available views

Need Review By (Date)

11/06

Urgency

medium

Steps to Test

  1. Log in to the Tugboat test site
  2. Create a Flexible Page. Add a "Developer's Catalog" component
  3. Confirm that the following views are not available as options for the "View" field anymore:
    • Editoria11y dismissals
    • Editoria11y results
    • Entity Reference Field Lists
    • External Authentication Links
    • Humsci Entity Lists
    • SAML Authentication Links

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat October 28, 2024 00:07 Destroyed
@cienvaras cienvaras marked this pull request as ready for review October 28, 2024 15:38
@cienvaras
Copy link
Collaborator Author

@ahughes3 Ready for review

Base automatically changed from 11.4.1-release to develop October 30, 2024 14:39
ahughes3
ahughes3 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 requested a review from joegl October 30, 2024 21:15
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 30, 2024
@cienvaras cienvaras changed the base branch from develop to 11.5.1-release October 30, 2024 21:55
@joegl joegl changed the title SHS-5881: Some views shouldn't be displayed in the developer's catalog SHS-5881: Adjust views available for use in the developer's catalog Oct 31, 2024
@joegl joegl merged commit cfd2f9a into 11.5.1-release Oct 31, 2024
17 checks passed
@joegl joegl deleted the shs-5881--developers-catalog-remove-views branch October 31, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl joegl approved these changes

@ahughes3 ahughes3 ahughes3 approved these changes

Assignees

@joegl joegl

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cienvaras @ahughes3 @joegl