Skip to content

Commit

Permalink
dropped ready for review title. added review tasks heading.
Browse files Browse the repository at this point in the history
  • Loading branch information
joegl committed Nov 19, 2024
1 parent 1fcb5c3 commit efe2264
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
# NOT READY FOR REVIEW
_[edit above to reflect status]_

## Summary
# Summary
_[briefly summarize the changes here. TL;DR - what's this PR for?]_

## Need Review By (Date)
Expand All @@ -14,6 +11,8 @@ _['low', 'medium', 'high', etc.]_
1. _[First testing step]_
2. ...

# Review Tasks

## Backend / Functional Validation
### Code
- [ ] Are the naming conventions following our standards?
Expand All @@ -28,6 +27,6 @@ _['low', 'medium', 'high', etc.]_
- [ ] Is all [user input properly sanitized when rendered](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)?
- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)?

## General
### General
- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
- [ ] Is the approach to the problem appropriate?

0 comments on commit efe2264

Please sign in to comment.