feat(ui5-user-menu): introduce new component #10244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add initials property of ProfileMenuAccount
adrian-bobev
changed the title
nnaydenow
reviewed
Nov 25, 2024
| }); | ||
|
|
||
| if (!eventPrevented) { | ||
| item.fireEvent("close-menu"); |
There was a problem hiding this comment.
Custom events have description about their bubble, cancelable configurations. This means that we need to fire events via fireDecoratorEvent in order to apply these configurations
There was a problem hiding this comment.
For some reason, it is not working. I guess because the MenuItem (which we extend) is still using the fireEvent. We can sync for that
There was a problem hiding this comment.
Most probably this will be resolved when the following PR is merged https://github.com/SAP/ui5-webcomponents/pull/10247/files
extract getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
PR checklist
Check the Development Hints
Follow the Commit message Guidelines
For example:
fix(ui5-*): correct/fix sthorfeat(ui5-*): add/introduce sth. If you don't want the change to be part of the release changelog - usechore,refactorordocs.Add proper description about the background of the change and the change itself
Link to an existing issue (if available)
Use
Fixes: {#PR_NUMBER}to close the issue automatically when the PR is mergedor
Related to: {#PR_NUMBER}to just create a link between the PR and the issue.