Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-button, ui5-link): support accessibile description #10212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

didip1000
Copy link
Contributor

Background

This change introduces the property accessibleDescription property to the ui5-lnk and ui5-button components. This new property enables developers to provide an accessible description, which sets the aria-description attribute for the component.

Usage:

To provide an accessible description for a Link or Button, you can use the accessibleDescription property as follows:

<ui5-link accessible-description="This is a link with a description"></ui5-link>

<ui5-Button accessible-description="This is a button with a description"></ui5-Button>

Related Issues:

@didip1000 didip1000 self-assigned this Nov 19, 2024
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accessibility announcements with NVDA, JAWS and voiceOver work as expected.

@unazko unazko marked this pull request as ready for review November 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants