Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-toolbar): fixed spacer behavior #10177

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

plamenivanov91
Copy link
Contributor

There was a bug where if there is a spacer before the last item, the last item would always overflow.
This change fixes the issue

Fixes: #10104

There was a bug where if there is a spacer before the last item, the
last item would always overflow.
This change fixes the issue

Fixes: SAP#10104
@plamenivanov91 plamenivanov91 marked this pull request as ready for review November 14, 2024 16:38
Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks and works good for me, only maybe we can add simple test.

@plamenivanov91 plamenivanov91 merged commit b3625ac into SAP:main Nov 18, 2024
10 checks passed
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.1 🎉

The release is available on v2.5.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-toolbar]: Overflow always open on last item with spacer
3 participants