Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-form): update to latest accessibility spec #10152

Merged
merged 10 commits into from
Nov 13, 2024
Merged

feat(ui5-form): update to latest accessibility spec #10152

merged 10 commits into from
Nov 13, 2024

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Nov 6, 2024 •
edited
Loading

The following accessibility changes are applied to the Form web component to full-fill the latest spec.

Form

  • form with groups has role="region"
  • form without groups have role="form"
  • form are referenced with the form header text (via aria-labelledby)

FormGroup

  • form groups are referenced with their form group header texts (via aria-labelledby)
  • form groups have role="form"
  • form groups create a fast navigation group - to jump from one group to another with F6

Fixes: #9952

@ilhan007 ilhan007 marked this pull request as ready for review November 6, 2024 16:24
nnaydenow
nnaydenow reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about form with only 1 group? Should it has role "region" or "form"?

packages/main/src/Form.ts Outdated Show resolved Hide resolved
nnaydenow
nnaydenow requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed offline.

packages/main/src/Form.ts Outdated Show resolved Hide resolved
packages/main/src/Form.ts Outdated Show resolved Hide resolved
nnaydenow
nnaydenow requested changes Nov 12, 2024
View reviewed changes
packages/main/src/Form.ts Outdated Show resolved Hide resolved
packages/main/src/Form.ts Show resolved Hide resolved
@ilhan007 ilhan007 merged commit 4382d4e into main Nov 13, 2024
10 checks passed
@ilhan007 ilhan007 deleted the feat-form-a11y branch November 13, 2024 11:23
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.0 🎉

The release is available on v2.5.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Form]: align with the latest a11y spec
3 participants
@ilhan007 @ui5-webcomponents-bot @nnaydenow