Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-badge & ui5-tag]: Incorrect / missing hover background color #10164

Closed
1 task done
HerzogIgzorn opened this issue Nov 8, 2024 · 1 comment · Fixed by #10229
Closed
1 task done

[ui5-badge & ui5-tag]: Incorrect / missing hover background color #10164

HerzogIgzorn opened this issue Nov 8, 2024 · 1 comment · Fixed by #10229
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@HerzogIgzorn
Copy link

HerzogIgzorn commented Nov 8, 2024

Bug Description

The background-color for the following WebComponents is incorrect when using color-scheme="9" and design="Set2":

  • ui5-tag
  • ui5-badge
<ui5-tag design="Set2" color-scheme="9" interactive="true">
    Color Scheme 9
</ui5-tag>

The issue is due to missing CSS in Tag-parameters.css. According to the Tag Design Spec, the correct color would be #F2F2F2. As you can see in the Tag-parameters.css of the base theme, the following definitions are missing but similar definitions exist for all other color-schemes (except 9):

--ui5-tag-set2-color-scheme-9-hover-background: var(--sapIndicationColor_9b_Hover_Background);

--ui5-tag-set2-color-scheme-9-active-color: var(--sapIndicationColor_9_Active_TextColor);
--ui5-tag-set2-color-scheme-9-active-background: var(--sapIndicationColor_9_Active_Background);
--ui5-tag-set2-color-scheme-9-active-border: var(--sapIndicationColor_9_Active_BorderColor);

f5acdada-88ff-40c6-bf01-db9b1b905d97

Affected Component

ui5-tag

Expected Behaviour

The missing CSS needs to be added for color-scheme="9" and design="Set2". This has to be done for the ui5-tag component in version 2.x as well as for the ui5-badge component in version 1.x

Isolated Example

WebComponent Playground

Steps to Reproduce

  1. Open the sample
  2. Hover over the tag "Color Scheme 9"

Priority

Medium

UI5 Web Components Version

1.x & 2.x & nightly

Browser

Chrome, Edge, Firefox, Safari

Operating System

Windows 11, MacOS, iOS, Android

Declaration

  • I’m not disclosing any internal or sensitive information.
@HerzogIgzorn HerzogIgzorn added the bug This issue is a bug in the code label Nov 8, 2024
@dobrinyonkov dobrinyonkov self-assigned this Nov 11, 2024
@dobrinyonkov
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd,

the hover and active (down) states of the tag in design "Set2" seems to not be according to the visual specification, could you please take over?

Kind Regards,
Dobrin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants