Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-badge): correct hover background color for Set 2 Color Scheme 9 #10233

Open
wants to merge 1 commit into
base: release-1.24
Choose a base branch
from
Open

fix(ui5-badge): correct hover background color for Set 2 Color Scheme 9 #10233

wants to merge 1 commit into from
+10 −0

Conversation

s-todorova
Copy link
Contributor

@s-todorova s-todorova commented Nov 21, 2024 •
edited
Loading

fixes: #10164
downport of #10229

@s-todorova s-todorova requested a review from a team November 21, 2024 15:37
LidiyaGeorgieva
LidiyaGeorgieva reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment for ui5-tag pull request is valid also here ("For horizon_dark maybe the parameters should be added also? Hover looks OK, but active - not.")
Maybe some parameter value is wrong?

@s-todorova
Copy link
Contributor Author

Active styles will be fixed with another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LidiyaGeorgieva LidiyaGeorgieva LidiyaGeorgieva approved these changes

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

@ilhan007 ilhan007 Awaiting requested review from ilhan007

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
1.24 downport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-todorova @LidiyaGeorgieva