-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING Guidelines #627
Add CONTRIBUTING Guidelines #627
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8c9f2fa - Browse repository at this point
Copy the full SHA 8c9f2faView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0066f9 - Browse repository at this point
Copy the full SHA c0066f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 400dfe5 - Browse repository at this point
Copy the full SHA 400dfe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c19fadd - Browse repository at this point
Copy the full SHA c19faddView commit details -
Add guidelines for TDD, PR workflow, and optimization
- Start with tests for new features - Open draft PR after initial functionality - Refactor, benchmark, and optimize - Offer support for test creation
Configuration menu - View commit details
-
Copy full SHA for 41db855 - Browse repository at this point
Copy the full SHA 41db855View commit details -
Update testing guidelines in CONTRIBUTING.md
- Encourage use of temporary unit tests during development - Clarify that rough, non-comprehensive tests are acceptable - Allow inclusion of temporary tests in pull requests - Explain rationale for removing tests before final merge: - Easier refactoring - Reduced necessity due to Rust's type system - Maintain instruction to run tests with 'cargo test'
Configuration menu - View commit details
-
Copy full SHA for dc85fe8 - Browse repository at this point
Copy the full SHA dc85fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6a9059 - Browse repository at this point
Copy the full SHA b6a9059View commit details
Commits on Oct 5, 2024
-
Contributing.md adds section on integration tests, improve new source…
… section Specifically notes some example tests and how they test. Also mentions sometimes you just have to listen, recommends adding example for that. Author: dvdsk <[email protected]> Date: Sat Oct 5 02:06:39 2024 +0200
Configuration menu - View commit details
-
Copy full SHA for dd3e8de - Browse repository at this point
Copy the full SHA dd3e8deView commit details -
Add Contributing guide and Integration Test guidelines
- Link to CONTRIBUTING.md in project root - New Integration Tests section: - Avoid sound output in tests - Tips for testing audio sources - Suggest examples for audible features - Note challenges in automated audio testing
Configuration menu - View commit details
-
Copy full SHA for d57e410 - Browse repository at this point
Copy the full SHA d57e410View commit details -
Merge branch 'add-contributing-guidelines' of https://github.com/Unkn…
…ownSuperficialNight/rodio into add-contributing-guidelines
Configuration menu - View commit details
-
Copy full SHA for 417d5a1 - Browse repository at this point
Copy the full SHA 417d5a1View commit details -
Merge: Integrate 'Integration Tests' from user dvdsk
- Incorporate Integration Tests contributed by dvdsk - Add leading numbers to bullet points mistakenly commited without numbering
Configuration menu - View commit details
-
Copy full SHA for 0aa7f5e - Browse repository at this point
Copy the full SHA 0aa7f5eView commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ab66761 - Browse repository at this point
Copy the full SHA ab66761View commit details