Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthesizer Waveforms #602
Synthesizer Waveforms #602
Changes from 10 commits
fc22b37
128fa74
8b08d12
eef2eda
107454e
7d4c9d7
2783904
b6c8a7e
1eabb21
84a008d
a015eb4
56d087a
0907857
87cd605
59a5b12
a012ac1
0c2c194
e060bdd
f3e77f4
28b7fc1
c912f56
cde724a
56fcce7
09c5f31
b373f52
5fa0188
371bbda
9d20ea2
44cb217
8899e67
a1fa144
322bdd5
1350246
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this:
is legal rust. So we could move SAMPLE_RATE into Sine like that. Then you could call
Self::SAMPLE_RATE
here which is slightly prettier?.