add support for Window::Focused/Unfocused events on macOS #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there was a slight oversight where the focus events were not sent correctly if the window contained other things besides just the NSView that houses the plugin. should be fixed now though, also added some comments for clarity. |
glowcoil
requested changes
Mar 24, 2024
glowcoil
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trigger
WindowEvent::FocusedandWindowEvent::Unfocusedevents when the plugin window gains/loses focus. implemented by adding observers toNSNotificationCenter::defaultCenter()that listen toNSWindowDidBecomeKeyNotificationandNSWindowDidResignKeyNotificationnotifications on theNSViews' window.tested and confirmed to work in Live, Bitwig, FL Studio, Reaper and AudioPluginHost.