Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context.cpp use empty() #294

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Update context.cpp use empty() #294

merged 5 commits into from
Apr 12, 2024

Conversation

andriish
Copy link
Contributor

@andriish andriish commented Apr 4, 2024

Update context.cpp use empty() to avoid clang-tidy warnings

@andriish
Copy link
Contributor Author

andriish commented Apr 8, 2024

Also contains #296

lyskov
lyskov reviewed Apr 8, 2024
View reviewed changes
source/context.cpp Outdated Show resolved Hide resolved
@andriish andriish requested a review from lyskov April 9, 2024 07:48
@andriish
Copy link
Contributor Author

@lyskov

lyskov
lyskov approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, - thank you @andriish !

@lyskov lyskov merged commit 0b961f2 into RosettaCommons:master Apr 12, 2024
17 checks passed
ldedier-gpfw pushed a commit to G-P-S/binder that referenced this pull request Sep 16, 2024
@andriish @ldedier-gpfw
update context.cpp use empty() to avoid clang-tidy warnings (Rosett…
2f0f98c 
…aCommons#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyskov lyskov lyskov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andriish @lyskov