Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] brand logo link not redirecting to / #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VenomFate-619
Copy link

@VenomFate-619 VenomFate-619 commented Jan 4, 2023

fixed Clicking on the rocket. chat brand logo does not redirect to the homepage
Issue: #211

Before

rocketBefore.mp4

Now

rocketChatBrandDesPR.mp4

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2023

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Jan 4, 2023

@Dnouv
Copy link
Member

Dnouv commented Jan 4, 2023

Hey @VenomFate-619
Thanks for the PR. The changes look good. However, sorry, but we can't merge it yet; you see, the changes are short, and it would be good if you could take on another issue and push the changes within this PR only, that will make it big.

Thank you!

@VenomFate-619
Copy link
Author

VenomFate-619 commented Jan 4, 2023

I found some more minor fixes like

  • The rocket chat logo in the footer not directing to rocket chat the main website
  • rocket chat in the menu bar of the mobile layout is doing a whole reload to get on the homepage instead it should be a client-side routing
    demo:-
rocketChat-menu.mp4

Should I also fix and push this in the same PR

@VenomFate-619
Copy link
Author

Hey @VenomFate-619 Thanks for the PR. The changes look good. However, sorry, but we can't merge it yet; you see, the changes are short, and it would be good if you could take on another issue and push the changes within this PR only, that will make it big.

Thank you!

ok I will look for other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants