Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosbag2-storage-mcap on linux-64 and win-64 #205

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions patch/ros-humble-pid-controller.patch
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
diff --git a/pid_controller/CMakeLists.txt b/pid_controller/CMakeLists.txt
index 15e903222a..6c9e00ef8b 100644
--- a/pid_controller/CMakeLists.txt
+++ b/pid_controller/CMakeLists.txt
@@ -45,7 +45,7 @@ ament_target_dependencies(pid_controller PUBLIC ${THIS_PACKAGE_INCLUDE_DEPENDS})
# Causes the visibility macros to use dllexport rather than dllimport,
# which is appropriate when building the dll but not consuming it.
-target_compile_definitions(pid_controller PRIVATE "PID_CONTROLLER_BUILDING_DLL")
+target_compile_definitions(pid_controller PRIVATE "PID_CONTROLLER__VISIBILITY_BUILDING_DLL")
pluginlib_export_plugin_description_file(controller_interface pid_controller.xml)
diff --git a/pid_controller/include/pid_controller/pid_controller.hpp b/pid_controller/include/pid_controller/pid_controller.hpp
index f7b8cc4491..788f39f1ed 100644
--- a/pid_controller/include/pid_controller/pid_controller.hpp
+++ b/pid_controller/include/pid_controller/pid_controller.hpp
@@ -121,8 +121,10 @@ class PidController : public controller_interface::ChainableControllerInterface
std::unique_ptr<ControllerStatePublisher> state_publisher_;
// override methods from ChainableControllerInterface
+ PID_CONTROLLER__VISIBILITY_PUBLIC
std::vector<hardware_interface::CommandInterface> on_export_reference_interfaces() override;
+ PID_CONTROLLER__VISIBILITY_PUBLIC
bool on_set_chained_mode(bool chained_mode) override;
// internal methods
diff --git a/pid_controller/CMakeLists.txt b/pid_controller/CMakeLists.txt
index 81cbe6f006..d7798b579b 100644
--- a/pid_controller/CMakeLists.txt
+++ b/pid_controller/CMakeLists.txt
@@ -45,7 +45,7 @@ ament_target_dependencies(pid_controller PUBLIC ${THIS_PACKAGE_INCLUDE_DEPENDS})

# Causes the visibility macros to use dllexport rather than dllimport,
# which is appropriate when building the dll but not consuming it.
-target_compile_definitions(pid_controller PRIVATE "PID_CONTROLLER_BUILDING_DLL")
+target_compile_definitions(pid_controller PRIVATE "PID_CONTROLLER__VISIBILITY_BUILDING_DLL")

pluginlib_export_plugin_description_file(controller_interface pid_controller.xml)

diff --git a/pid_controller/include/pid_controller/pid_controller.hpp b/pid_controller/include/pid_controller/pid_controller.hpp
index 105a915442..4919a739ce 100644
--- a/pid_controller/include/pid_controller/pid_controller.hpp
+++ b/pid_controller/include/pid_controller/pid_controller.hpp
@@ -119,8 +119,10 @@ class PidController : public controller_interface::ChainableControllerInterface
std::unique_ptr<ControllerStatePublisher> state_publisher_;

// override methods from ChainableControllerInterface
+ PID_CONTROLLER__VISIBILITY_PUBLIC
std::vector<hardware_interface::CommandInterface> on_export_reference_interfaces() override;

+ PID_CONTROLLER__VISIBILITY_PUBLIC
bool on_set_chained_mode(bool chained_mode) override;

// internal methods
3 changes: 3 additions & 0 deletions vinca_linux_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ packages_skip_by_deps:
# - diagnostic_updater
- cartographer
- octomap
- pid-controller
- rosx-introspection

packages_remove_from_deps:
- cartographer
Expand Down Expand Up @@ -139,6 +141,7 @@ packages_select_by_deps:

- gtsam
- motion-capture-tracking
- rosbag2-storage-mcap

# Needs fixing
# - moveit-resources
Expand Down
1 change: 1 addition & 0 deletions vinca_win.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ packages_select_by_deps:
- gazebo-ros2-control
- ros2-controllers-test-nodes
- joint-state-publisher-gui
- rosbag2-storage-mcap

# Broken for now until we migrate to newer gazebo
# - desktop_full
Expand Down
Loading