rework to use smart SPI flash detection #2670
Open
+116
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check JEDEC ID is in range between 0x0001 ... 0xFFFE, Compare the output from 0x90 and 0x9F, Then the size from the JEDEC ID Otherwise fall-back to 256 kB Extend the spi_flash_decode.py to handle more (known) SPI flash ICs
jmichelp
reviewed
Dec 2, 2024
| // default device is 'unknown' | ||
| spi_flash_data.device = SpiFlashTable[0].device; | ||
|
|
||
| // Check JEDEC datais valid, compare the reported device types and then calcualte the number of pages |
There was a problem hiding this comment.
typos: Missing space and inverted letters
| } | ||
| if (spi_flash_data.jedec_id > 0 && spi_flash_data.jedec_id < 0xFFFF) { | ||
| uint8_t jedec_p64k = (1 << (spi_flash_data.jedec_id & 0x000F)) & 0xFF; | ||
| uint8_t deviceid_p64k = (1 << ((spi_flash_data.device_id & 0x0F) + 1)) & 0xFF; |
There was a problem hiding this comment.
You don't need to compute this shift.
Checking that (spi_flash_data.device_id + 1) & 0x0f == (spi_flash_data.jedec_id & 0x0f) should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check JEDEC ID is in range between 0x0001 ... 0xFFFE, Compare the output from 0x90 and 0x9F,
Then the size from the JEDEC ID
Otherwise fall-back to 256 kB
Extend the spi_flash_decode.py to handle more (known) SPI flash ICs