Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do fixes for Gekko mutexes, implement 3DS mutexes #377

Merged

Conversation

CasualPokePlayer
Copy link
Contributor

@CasualPokePlayer CasualPokePlayer commented Oct 12, 2024

These lines from RetroArch probably should be removed after this PR is in RetroArch's rcheevos copy. https://github.com/libretro/RetroArch/blob/228426880babb529fae8f01598a6d34698ad3b18/griffin/griffin.c#L193-L195

Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way to test this. Looks reasonable.

@Jamiras
Copy link
Member

Jamiras commented Oct 26, 2024

#378 (comment)

Note probably want to introduce an !defined(_3DS) for the _XOPEN_SOURCE define guard when #377 is merged.

@Jamiras Jamiras merged commit 61fd958 into RetroAchievements:develop Nov 2, 2024
7 checks passed
@Jamiras Jamiras added this to the 11.7.0 milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants