fix infinite loop if reset occurs just prior to a ping while progress indicator is on screen #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
rc_client_reset
with a progress indicator on screen, the progress indicator is immediately hidden and the scheduled event to hide it is removed from the queue. This is done by changing it's scheduled time to 0. Since the queue is sorted, the scan to remove the item stops as soon as an item is found with a higher scheduled time. As a result, if the event is not the first item in the queue, it's not removed. Instead, it gets reinserted as the first item, pointing at the previous first item, which is still pointing at the chain that is pointing at it. The next time the queue is updated, there's a potential infinite loop as it looks for a place to insert the new item.