Raise exception if trying to set a dict with no id as property value #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichad
approved these changes
Sep 10, 2024
test/test_model.py
Outdated
Comment on lines
366
to
370
| with open(crate_dir / helpers.METADATA_FILE_NAME, "wt") as f: | ||
| json.dump(metadata, f, indent=4) | ||
| with pytest.raises(ValueError): | ||
| crate = ROCrate(crate_dir) | ||
| del metadata["@graph"][2]["badProp"] |
There was a problem hiding this comment.
Could you add a couple of comments to indicate the different things that are being tested here? With line 368-9 in particular, it's not intuitive that that part of the test relates to this specific issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190.
Adds a check for dict values without
@idtoEntity.__setitem__.